vreplication: refactor table_plan_builder#5159
Merged
sougou merged 1 commit intovitessio:masterfrom Sep 6, 2019
Merged
Conversation
Unify the code path for wildcard and exact table name matches. The diverging paths have been a source of bugs. This unification will also help with the next feature that will allow us to exclude tables in the filtering rules. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
|
oooops! |
Contributor
Author
|
😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify the code path for wildcard and exact table name matches.
The diverging paths have been a source of bugs.
This unification will also help with the next feature that will
allow us to exclude tables in the filtering rules.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com