replication_reporter: Don't try to reparent to yourself.#5157
Merged
sougou merged 1 commit intovitessio:masterfrom Sep 6, 2019
Merged
replication_reporter: Don't try to reparent to yourself.#5157sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen it happen that a master tablet restarts and becomes a
replica. If the shard record still says we are master, we might end up
trying to reparent to ourselves.
I don't know yet how the tablet is getting forced to replica type, but
in any case we should enforce the invariant that we don't try to
reparent to ourselves.
Signed-off-by: Anthony Yeh enisoc@planetscale.com