Skip to content

Handle case where mysqld replies to Initial Handshake Packet with an ERR packet#5149

Merged
sougou merged 1 commit intovitessio:masterfrom
adsr:imm_handshake_err
Aug 30, 2019
Merged

Handle case where mysqld replies to Initial Handshake Packet with an ERR packet#5149
sougou merged 1 commit intovitessio:masterfrom
adsr:imm_handshake_err

Conversation

@adsr
Copy link
Copy Markdown
Collaborator

@adsr adsr commented Aug 29, 2019

From mysql docs:

It starts with the client connect()ing to the server which may send a
ERR packet and finish the handshake or send a Initial Handshake
Packet...

sql_state fields are skipped because they are not set according to docs.

Note
In case the server sent a ERR packet as first packet it will happen
before the client and server negotiated any capabilities. Therefore
the ERR packet will not contain the SQL-state.

Signed-off-by: Adam Saponara as@php.net

…ERR packet.

From mysql docs:

```
It starts with the client connect()ing to the server which may send a
ERR packet and finish the handshake or send a Initial Handshake
Packet...
```

`sql_state` fields are skipped because they are not set according to docs.

```
Note
In case the server sent a ERR packet as first packet it will happen
before the client and server negotiated any capabilities. Therefore
the ERR packet will not contain the SQL-state.
```

Signed-off-by: Adam Saponara <as@php.net>
@adsr adsr requested a review from sougou as a code owner August 29, 2019 22:36
@sougou sougou merged commit 3ce4e05 into vitessio:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants