Skip to content

Orc basic auth with vttablet flags#5143

Merged
sougou merged 1 commit intovitessio:masterfrom
msolters:orc-basic-auth
Aug 29, 2019
Merged

Orc basic auth with vttablet flags#5143
sougou merged 1 commit intovitessio:masterfrom
msolters:orc-basic-auth

Conversation

@msolters
Copy link
Contributor

@msolters msolters commented Aug 28, 2019

Implement a way to authenticate with Orchestrator via HTTP basic auth by passing the optional flags.

  • -orc_api_user
  • -orc_api_password

Omitting orc_api_user skips authentication.

This has been tested to work in our k8s-based vitess cluster.

Signed-off-by: Mark Solters msolters@gmail.com

Signed-off-by: Mark Solters <msolters@gmail.com>
@msolters msolters requested a review from sougou as a code owner August 28, 2019 16:14
@sougou sougou requested a review from dkhenry August 28, 2019 16:56
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straighforward.

@sougou sougou merged commit f6a612a into vitessio:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants