Subtraction operation implementation#5140
Merged
sougou merged 14 commits intovitessio:masterfrom Sep 12, 2019
Merged
Conversation
added 5 commits
August 26, 2019 16:34
Signed-off-by: Rasika Kale <rasika@planetscale.com> Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
- Added more tests in arithmetic_test.go to fix code coverage - Added error checking into arithmetic.go - Implemented function floatMinusAny() for subtraction expression Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
sougou
reviewed
Aug 28, 2019
added 5 commits
August 30, 2019 11:22
- Added intMinusUintWithError() in arithmetic.go - Fixed error checking in arithmetic.go for intMinusIntWithError() Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
- Added test for method in arithmetic_test.go to maximize code coverage Signed-off-by: Rasika Kale <rasika@planetscale.com>
- Fixed tests in TestAdd() in arithmetic_test.go Signed-off-by: Rasika Kale <rasika@planetscale.com>
sougou
reviewed
Sep 9, 2019
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
A few more corner cases to handle.
added 4 commits
September 10, 2019 09:51
- checked if v1 < 0 in intMinusUintWithError() - checked if v2 is greater that v1 and greater than 0 in uintMinusIntWithError()_ - within uintMinusIntWithError() checked if v2 < 0, then returned uintPlusIntWithError(v1, -v2) - checked if v2 > v1 in uintMinusUintWithError() - Added function floatMinusAny() in subtractNumericWithError() to account for float - value expressions Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
sougou
approved these changes
Sep 12, 2019
Contributor
|
Nice work! |
deepthi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial fix for #5098
Subtract()to return a Value or an error. The output of this function represents the same output when two values are subtracted from each other in MySQL. The following functions were added to achieve this:subtractNumericWithError()- operates the same way asaddNumericWithError(), and returns a numeric or an errorintMinusIntWithError()- operates the same way asintPlusIntWithError(), except both values are subtracted.uintMinusIntWithError()- Checks whether first value if less than second value. If so, then returns a BIGINT UNSIGNED error.uintMinusUintWithError()- Returns the difference of two uint64 values as a uint64 value. Returns the uint64 value as a numeric.floatMinusAny()- Returns a numeric float64 value after subtracting a float and non-float value