vtexplain support select distinct and other expressions#5139
Merged
sougou merged 3 commits intovitessio:masterfrom Aug 30, 2019
Merged
vtexplain support select distinct and other expressions#5139sougou merged 3 commits intovitessio:masterfrom
sougou merged 3 commits intovitessio:masterfrom
Conversation
Rework the vtexplain simulated mysql to handle more expression types when calculating fake column results based on inferences off the select expression. Also change the engine so that it logs an error instead of failing outright, since the column values aren't always needed for it to effectively simulate a query. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
sougou
approved these changes
Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
select distinct,substr,case, and more expressions to vtexplain.Description
Part of the vtexplain execution engine fabricates query results, and so it needs to know the type of each column that should be in the result set.
Rework the analyzer that infers the column type from the select expression so that it handles parenthesized expressions like substr and select distinct(col), as well as case expressions.
Also change the engine so that it logs an error instead of failing outright if it can't resolve an expression to a column type, since the column values aren't always needed for it to effectively simulate a query.