vreplication: improved rowstreamer#5130
Merged
sougou merged 2 commits intovitessio:masterfrom Sep 4, 2019
Merged
Conversation
For composite primary keys, mysql comes up with a full table scan for conditions like (pk1,pk2) > (1, 2). This change rewrites that condition to: (pk1 = 1 and pk2 > 2) or (pk1 > 1) Also removed the autocommit=0. It's not material to set that for obtaining read locks. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
reviewed
Aug 26, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
It is obvious that the code can handle an arbitrary number of PK columns. The tests currently have 1 or 2 PKs. What do you think of adding a test with 3 PK columns?
Looks good otherwise.
Contributor
Author
|
I thought about that. Was borderline on the 3-pk case. I can add a test. |
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For composite primary keys, mysql comes up with a full table scan
for conditions like (pk1,pk2) > (1, 2).
This change rewrites that condition to:
(pk1 = 1 and pk2 > 2) or (pk1 > 1)
Also removed the autocommit=0. It's not material to set that for
obtaining read locks.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com