Empty results should return a count of 0 but a sum of null.#5121
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 23, 2019
Merged
Empty results should return a count of 0 but a sum of null.#5121sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
mpawliszyn
force-pushed
the
mikepaw.fix-sum-count
branch
from
f233f7b to
63c7e9d
Compare
systay
approved these changes
Aug 23, 2019
Collaborator
systay
left a comment
systay
left a comment
There was a problem hiding this comment.
Ooops! Thanks for fixing this.
Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
mpawliszyn
force-pushed
the
mikepaw.fix-sum-count
branch
from
63c7e9d to
e94f297
Compare
Collaborator
Author
|
@sougou the tests should pass now. Could I get a stamp? |
sougou
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Pawliszyn mikepaw@squareup.com