Make it possible to send span context over the MySQL end point#5118
Merged
sougou merged 6 commits intovitessio:masterfrom Sep 5, 2019
Merged
Make it possible to send span context over the MySQL end point#5118sougou merged 6 commits intovitessio:masterfrom
sougou merged 6 commits intovitessio:masterfrom
Conversation
Collaborator
Author
|
@alecthomas if you can spare the time, I would love to get your critique my golang abuse. |
added 4 commits
August 21, 2019 13:26
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
systay
force-pushed
the
span_over_mysql
branch
from
39320c6 to
fd131c8
Compare
added 2 commits
August 21, 2019 15:29
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
sougou
approved these changes
Sep 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows sending span context (something that carries data across process boundaries) over the MySQL protocol, by embedding it into the query in the form of a comment.
Example: