vreplication: bug: make row streaming more robust#5114
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 21, 2019
Merged
vreplication: bug: make row streaming more robust#5114sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
During production testing, we found that there are possibilities that a table lock never gets released when row streaming is requested. We most likely suspect that a grpc send hangs, which keeps the table locked, when eventually causes replication to stall and subsequent row streaming requests to hang. This change refactors the code to make sure that we unlock a table as soon as streaming has started. The previous code unlocked the table only after sending the field info. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
approved these changes
Aug 21, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
lgtm.
Q: has this fix already been tried out on a production scale resharding?
Contributor
Author
|
The testing is still being done. But this is overall an improvement, even if it didn't address the specific issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During production testing, we found that there are possibilities
that a table lock never gets released when row streaming is requested.
We most likely suspect that a grpc send hangs, which keeps the table
locked, when eventually causes replication to stall and subsequent
row streaming requests to hang.
This change refactors the code to make sure that we unlock a table
as soon as streaming has started. The previous code unlocked the table
only after sending the field info.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com