Skip to content

docker: vitess/k8s: Include all my.cnf template files.#5068

Merged
enisoc merged 1 commit intovitessio:masterfrom
planetscale:docker-mycnf
Aug 9, 2019
Merged

docker: vitess/k8s: Include all my.cnf template files.#5068
enisoc merged 1 commit intovitessio:masterfrom
planetscale:docker-mycnf

Conversation

@enisoc
Copy link
Copy Markdown
Member

@enisoc enisoc commented Aug 9, 2019

There are now a larger set of required templates (since #4987) because we have auto-included files for every minor version (e.g. 5.6 vs 5.7). Just include everything instead of trying to pick and choose.

Signed-off-by: Anthony Yeh enisoc@planetscale.com

There are now a larger set of required templates because we have
auto-included files for every minor version (e.g. 5.6 vs 5.7).
Just include everything instead of trying to pick and choose.

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
@enisoc enisoc requested a review from deepthi August 9, 2019 05:30
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can merge after CI passes.

@enisoc enisoc merged commit edc2a24 into vitessio:master Aug 9, 2019
@enisoc enisoc deleted the docker-mycnf branch August 9, 2019 06:04
morgo pushed a commit to planetscale/vitess that referenced this pull request Aug 9, 2019
There are now a larger set of required templates because we have
auto-included files for every minor version (e.g. 5.6 vs 5.7).
Just include everything instead of trying to pick and choose.

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants