Improve Config Files (followup from capabilities)#5061
Closed
morgo wants to merge 24 commits intovitessio:masterfrom
Closed
Improve Config Files (followup from capabilities)#5061morgo wants to merge 24 commits intovitessio:masterfrom
morgo wants to merge 24 commits intovitessio:masterfrom
Conversation
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
They will default to MySQL56 (=MySQL57 usually). When running tests against a non-MySQL56 flavor, it will be required to still specify MYSQL_FLAVOR. Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
57b6a3b to
7c9da50
Compare
Signed-off-by: Morgan Tocker <tocker@gmail.com>
c06b6a5 to
5a8b3fd
Compare
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
…into morgo-update-configs Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
…into morgo-update-configs Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
…into morgo-update-configs Signed-off-by: Morgan Tocker <tocker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #4987
It cleans up the config files and renames them into a convention that makes more sense for the current usage. It also fixes
test/local_example.shto use etcd2 as the tutorials on vitess.io have switched to it.Full config changes:
One change that it doesn't make, is that the Python default
MYSQL_FLAVORis still MariaDB. When I changed this to MySQL56 the testsuite wouldn't pass (it failed in local_example trying to download maven files). This will have to be looked at as a followup.Signed-off-by: Morgan Tocker tocker@gmail.com