Add ability to process vschema migrations during vttestserver startup#5054
Merged
tirsen merged 1 commit intovitessio:masterfrom Aug 12, 2019
Merged
Conversation
Contributor
|
Looks like the tests need fixing. |
kalfonso
force-pushed
the
kalfonso.190801-vttestserver-alter-vschema
branch
2 times, most recently
from
b0c22a3 to
db8b83e
Compare
kalfonso
commented
Aug 6, 2019
kalfonso
force-pushed
the
kalfonso.190801-vttestserver-alter-vschema
branch
3 times, most recently
from
fe5b599 to
f612783
Compare
Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com>
kalfonso
force-pushed
the
kalfonso.190801-vttestserver-alter-vschema
branch
from
f612783 to
aa33b3a
Compare
tirsen
approved these changes
Aug 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows defining vschema changes during testing using "ALTER VSCHEMA" statements which follows a convention "v[0-9]{3}__\w+" in the specified "schemaDir" while still supporting an initial "vschema.json" file.
The vschema migrations are located in same directory as db migrations to keep same developer experience. The migration is routed to the db or topology based on the content. We're constraining one single vschema migration per file.
Signed-off-by: Karel Alfonso Sague kalfonso@squareup.com