Add Support for Prepared Statements#5018
Merged
sougou merged 43 commits intovitessio:masterfrom Aug 9, 2019
Merged
Conversation
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
…s-prepare Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
…tiglabs-prepare Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Member
|
We could definitely use support for prepared statements |
sougou
reviewed
Jul 28, 2019
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Excellent piece of work! I only have a few nit-picks.
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
deepthi
reviewed
Aug 1, 2019
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
sougou
reviewed
Aug 9, 2019
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
I was about to approve, but found a potential bug. Can you write a test for it?
Make sure it fails, and then make sure the fix fixes the problem.
sougou
reviewed
Aug 9, 2019
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
…not get affacted Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation for #3862.
Added unit tests and end to end tests to ensure that Prepared statements is working properly.
cc: @dcadevil @Johnny-Three