messages: add support for topics that route inserts to multiple subscriber message tables#5011
Merged
sougou merged 6 commits intovitessio:masterfrom Aug 17, 2019
Merged
Conversation
derekperkins
force-pushed
the
message-topics-pseudo-table
branch
2 times, most recently
from
07c9490 to
c7841d7
Compare
derekperkins
changed the title
derekperkins
force-pushed
the
message-topics-pseudo-table
branch
from
833db19 to
f71473b
Compare
derekperkins
commented
Jul 23, 2019
derekperkins
force-pushed
the
message-topics-pseudo-table
branch
2 times, most recently
from
dd4f5b8 to
d68498e
Compare
derekperkins
changed the title
Member
Author
|
@sougou this is ready for review when you have time |
derekperkins
commented
Jul 26, 2019
sougou
reviewed
Jul 28, 2019
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Nice work. I've suggested some minor adjustments.
derekperkins
force-pushed
the
message-topics-pseudo-table
branch
from
e2ad0a7 to
612a213
Compare
derekperkins
commented
Aug 1, 2019
derekperkins
force-pushed
the
message-topics-pseudo-table
branch
from
fbb0c0d to
5e9abb8
Compare
derekperkins
force-pushed
the
message-topics-pseudo-table
branch
from
5e9abb8 to
f125874
Compare
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
derekperkins
force-pushed
the
message-topics-pseudo-table
branch
from
f125874 to
24d3d1b
Compare
sougou
approved these changes
Aug 17, 2019
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Very nice work. The whole PR reads very well. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #4956 to solve #4940. Instead of having topics separate from tables, it adds topics as pseudo tables.