Merged
Conversation
Partially addresses vitessio#4990 Signed-off-by: Morgan Tocker <tocker@gmail.com>
…figs2 Signed-off-by: Morgan Tocker <tocker@gmail.com>
Member
|
FWIW, this broke some of my 8.0 tablets, specifically removing I had tablets that were initialized with this flag, then when it was removed on startup and defaulted to 12M, I got into an infinite loop where mysql would exit because the file was an incompatible size, and vttablet kept restoring the old file when I tried to delete it. That doesn't mean this should be rolled back, but it took me a long time to track this down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses some of the easiest suggestions in #4990.
Because this config file is used by multiple versions of MySQL, not all changes are possible. After #4987 merges, the settings only required by MySQL 5.6 (such as sql_mode) can be moved to a separate file and further cleanup is possible.
I will add future improvements in followup PRs, after splitting config file per version.
Signed-off-by: Morgan Tocker tocker@gmail.com