Skip to content

Adjust variable declaration format #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luky-pc wants to merge 3 commits into from
Closed

Adjust variable declaration format #4874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3741b6e
Adjust variable declaration format
luky-pc May 25, 2019
3d3b86a
need space on the left of =
luky-pc May 25, 2019
55ce6a1
should use ' to replace of "
luky-pc May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions web/vtctld2/src/app/shared/dialog/dialog-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ export class DialogSettings {
public respText: string;
public errMsg: string;
public logText: string;
public open= false;
public dialogForm= true;
public dialogLog= false;
public pending= false;
public onCloseFunction= undefined;
public open = false;
public dialogForm = true;
public dialogLog = false;
public pending = false;
public onCloseFunction = undefined;

constructor(actionWord = '', dialogTitle = '', dialogSubtitle = '', errMsg = '') {
this.actionWord = actionWord;
Expand Down
18 changes: 9 additions & 9 deletions web/vtctld2/src/app/workflows/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const enum ActionStyle {
TRIGGERED,
}

/*
/*
Object for any action buttons you want the UI to display to the user.
Default behavior should be that Action.message appears as a tooltip.
*/
Expand Down Expand Up @@ -71,14 +71,14 @@ export class Node {
public name: string;
public path: string; // Path to element Ex, “GrandparentID/ParentId/ID”.
public children: Node[];
public lastChanged= 0; // Time last changed in seconds.
public progress= 0; // Should be an int from 0-100 for percentage
public progressMsg= ''; // Ex. “34/256” “25%” “calculating”
public state= State.NOT_STARTED;
public display= Display.NONE;
public message= ''; // Instructions for user
public log= ''; // Log from command
public disabled= false; // Use for blocking further actions
public lastChanged = 0; // Time last changed in seconds.
public progress = 0; // Should be an int from 0-100 for percentage
public progressMsg = ''; // Ex. “34/256” “25%” “calculating”
public state = State.NOT_STARTED;
public display = Display.NONE;
public message = ''; // Instructions for user
public log = ''; // Log from command
public disabled = false; // Use for blocking further actions
public actions: Action[];

constructor(name: string, path: string, children: any) {
Expand Down
2 changes: 1 addition & 1 deletion web/vtctld2/src/app/workflows/workflow-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export class WorkflowListComponent implements OnDestroy, OnInit {
for (let i=0; i<phaseEnableApprovalCheckBoxNames.length; i++) {
let phaseName = phaseEnableApprovalCheckBoxNames[i];
if(newFlags[factoryName + '_' + phaseName]['value']) {
phaseEnableApprovals.push(newFlags[factoryName + '_' + phaseName]["namedPositional"]);
phaseEnableApprovals.push(newFlags[factoryName + '_' + phaseName]['namedPositional']);
}
// We don't want this flag to show up in the getArgs
delete newFlags[factoryName + '_' + phaseName];
Expand Down