Skip to content

Fix docker build issues for MySQL 8#4840

Merged
deepthi merged 2 commits intovitessio:masterfrom
msolters:mysql-8-docker-fixes
Apr 25, 2019
Merged

Fix docker build issues for MySQL 8#4840
deepthi merged 2 commits intovitessio:masterfrom
msolters:mysql-8-docker-fixes

Conversation

@msolters
Copy link
Copy Markdown
Contributor

@msolters msolters commented Apr 25, 2019

MySQL/Percona 8 containers were being built with the incorrect Dockerfiles and were not receiving the v8.0 my.cnf files they were expecting.

I also deleted some very important-looking whitespace, so let me know if I need to put that back.

Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If you don't mind, can you also fix the docker_base_percona80 target in the Makefile?
oh also, fix the DCO by amending your commit with --signoff

Signed-off-by: Mark Solters <msolters@gmail.com>
Signed-off-by: Mark Solters <msolters@gmail.com>
@msolters msolters force-pushed the mysql-8-docker-fixes branch from e891f2a to 9e982ea Compare April 25, 2019 20:18
@deepthi deepthi merged commit fac8498 into vitessio:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants