Skip to content

Small bug: Comments and function names do not match #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 1 commit into from
Apr 16, 2019
Merged

Small bug: Comments and function names do not match #4813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type builder interface {
// execute before this one.
Reorder(int)

// Primitve returns the underlying primitive.
// Primitive returns the underlying primitive.
Primitive() engine.Primitive

// First returns the first builder of the tree,
Expand Down
10 changes: 6 additions & 4 deletions go/vt/vtgate/vindexes/lookup_unicodeloosemd5_hash_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ import (
topodatapb "vitess.io/vitess/go/vt/proto/topodata"
)

const hashed10 uint64 = 17563797831108199066
const hashed20 uint64 = 8729390916138266389
const hashed30 uint64 = 1472608112194674795
const hashed40 uint64 = 16576388050845489136
const (
hashed10 uint64 = 17563797831108199066
hashed20 uint64 = 8729390916138266389
hashed30 uint64 = 1472608112194674795
hashed40 uint64 = 16576388050845489136
)

func TestLookupUnicodeLooseMD5HashMap(t *testing.T) {
lookup := createLookup(t, "lookup_unicodeloosemd5_hash", false)
Expand Down
6 changes: 4 additions & 2 deletions go/vt/vtgate/vtgateconntest/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,10 @@ type fakeVTGateService struct {
errorWait chan struct{}
}

const expectedErrMatch string = "test vtgate error"
const expectedCode vtrpcpb.Code = vtrpcpb.Code_INVALID_ARGUMENT
const (
expectedErrMatch string = "test vtgate error"
expectedCode vtrpcpb.Code = vtrpcpb.Code_INVALID_ARGUMENT
)

var errTestVtGateError = vterrors.New(expectedCode, expectedErrMatch)

Expand Down