Skip to content

orchestrator: Add more detail to error messages. #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 1 commit into from
Apr 5, 2019
+2 −2
Merged

orchestrator: Add more detail to error messages. #4788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/vt/vttablet/tabletmanager/orchestrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,13 @@ func (orc *orcClient) InActiveShardRecovery(tablet *topodatapb.Tablet) (bool, er
resp, err := orc.apiGet("audit-recovery", "alias", alias)

if err != nil {
return false, err
return false, fmt.Errorf("error calling Orchestrator API: %v", err)
}

var r []map[string]interface{}

if err := json.Unmarshal(resp, &r); err != nil {
return false, err
return false, fmt.Errorf("error parsing JSON response from Orchestrator: %v; response: %q", err, string(resp))
}

// Orchestrator returns a 0-length response when it has no history of recovery on this cluster.
Expand Down