Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions go/vt/topotools/rebuild_keyspace.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ func RebuildKeyspaceLocked(ctx context.Context, log logutil.Logger, ts *topo.Ser
}

// This is safe to rebuild as long there are not srvKeyspaces with tablet controls set.
// TODO: Add this validation.

// Build the list of cells to work on: we get the union
// of all the Cells of all the Shards, limited to the provided cells.
//
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vttablet/tabletmanager/init_tablet.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (agent *ActionAgent) InitTablet(port, gRPCPort int32) error {
case err == nil:
// NOOP
case topo.IsErrType(err, topo.NoNode):
err = topotools.RebuildKeyspaceLocked(ctx, logutil.NewConsoleLogger(), agent.TopoServer, *initKeyspace, []string{agent.TabletAlias.Cell})
err = topotools.RebuildKeyspace(ctx, logutil.NewConsoleLogger(), agent.TopoServer, *initKeyspace, []string{agent.TabletAlias.Cell})
default:
return vterrors.Wrap(err, "InitTablet failed to read srvKeyspace")
}
Expand Down
2 changes: 1 addition & 1 deletion go/vt/wrangler/keyspace.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func (wr *Wrangler) printShards(ctx context.Context, si []*topo.ShardInfo) error
wr.Logger().Printf(" %v\n", row)
}
}
wr.Logger().Printf(" Served Types: %v\n", si.IsMasterServing)
wr.Logger().Printf(" Is Master Serving: %v\n", si.IsMasterServing)
if len(si.TabletControls) != 0 {
wr.Logger().Printf(" Tablet Controls: %v\n", si.TabletControls)
}
Expand Down