Skip to content

MySQL 8.0 should be started with mysqlx=0#4725

Merged
derekperkins merged 3 commits intovitessio:masterfrom
planetscale:ds-mysql80-docker
Apr 9, 2019
Merged

MySQL 8.0 should be started with mysqlx=0#4725
derekperkins merged 3 commits intovitessio:masterfrom
planetscale:ds-mysql80-docker

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Mar 15, 2019 •
edited
Loading

Signed-off-by: deepthi deepthi@planetscale.com

@derekperkins are there other things we need to fix up for 8.0?

deepthi
deepthi commented Mar 15, 2019
View reviewed changes
config/mycnf/master_mysql80.cnf Outdated
Copy link
Copy Markdown
Collaborator Author

@deepthi deepthi Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something we can delete for 8.0?

Copy link
Copy Markdown
Contributor

@dkhenry dkhenry Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the manual you still need the plugin in mysql 8.0

https://dev.mysql.com/doc/refman/8.0/en/replication-semisync-installation.html

@derekperkins
Copy link
Copy Markdown
Member

derekperkins commented Mar 15, 2019

There are definitely more things to change. I didn't know we had decided to add a new flavor. Why are you setting mysqlx=0? These are two that are definitely required.

default_authentication_plugin   = mysql_native_password
secure_file_priv                = NULL

Offhand, other ones that we might do are

character-set-server            = utf8mb4
collation-server                = utf8mb4_0900_ai_ci

@sjmudd is probably a better judge of good defaults.

@deepthi
Copy link
Copy Markdown
Collaborator Author

deepthi commented Mar 15, 2019 •
edited
Loading

There are definitely more things to change. I didn't know we had decided to add a new flavor. Why are you setting mysqlx=0? These are two that are definitely required.

default_authentication_plugin   = mysql_native_password
secure_file_priv                = NULL

Offhand, other ones that we might do are

character-set-server            = utf8mb4
collation-server                = utf8mb4_0900_ai_ci

@sjmudd is probably a better judge of good defaults.

There wasn't actually a decision / discussion on whether to create a new flavor, but it seems like the config differences do require a new flavor.

@derekperkins re: mysqlx, either we need to disable it or change our tests to provide a separate port to each mysql instance. otherwise all the test mysqlds try to use the same default port for mysqlx and fail to start.

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Mar 31, 2019

@derekperkins: I'll let you review and merge this.

@derekperkins
Copy link
Copy Markdown
Member

derekperkins commented Apr 7, 2019

The cnf file looks fine. I'm not super familiar with where new flavors need to be registered, but comparing with @dkhenry adding a MariaDB 10.3 flavor, there are a couple places that seem to be missing. https://github.com/vitessio/vitess/pull/4193/files

https://github.com/vitessio/vitess/blob/master/go/vt/vttest/environment.go#L120
https://github.com/vitessio/vitess/blob/master/py/vttest/mysql_flavor.py#L99

deepthi added 3 commits April 8, 2019 15:19
@deepthi
MySQL 8.0 should be started with mysqlx=0
a3b7b04 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
add auth config, add MySQL80 flavor handling in mysqld
595448a 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
add mysql80 flavor to vttest
d409c44 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi force-pushed the ds-mysql80-docker branch from 3b9569e to d409c44 Compare April 9, 2019 01:16
@deepthi
Copy link
Copy Markdown
Collaborator Author

deepthi commented Apr 9, 2019

@derekperkins thanks for the pointers. I fixed those and now I can get docker tests passing locally with the mysql80 flavor.

@derekperkins derekperkins merged commit 8799db9 into vitessio:master Apr 9, 2019
@setassociative setassociative mentioned this pull request Apr 26, 2019
Merged
setassociative pushed a commit to tinyspeck/vitess that referenced this pull request Apr 26, 2019
Merge upstream 2019-04-25 (#130)
3489b15 
It's been busy and exciting in vitess upstream. Some changes that felt worth calling out as they could impact assumptions about behavior:

- vitessio#4832 — this adds a timeout that is 3x the `healthCheckInterval` which at which point the tablet will stop reporting as healthy
- vitessio#4814 — this changes when command line args are used by vttablet
- vitessio#4811 — a planned reparent now sets `super_read_only`
- vitessio#4805 — behavior coming back from a failed backup is different

**Slack changes**  
        @demmer vitessio#4827 Correct suppress logging for begin...commit in autocommit
        @rafael vitessio#4824 adds timeouts for all statements
        @demmer vitessio#4826 adds logging of stack traces as opt-in
        @demmer vitessio#4819 remove begin/commit logs from autocommit txns
        @demmer vitessio#4796 improves support for vtexplain for begin/dml/dml/commit txns

**Non slack changes**  
        vitessio#4839 Improve behavior with reference table routing & vreplication
        vitessio#4833 Support query routing given there could be multiple targets for a table
        vitessio#4832 tablets get new health check behavior (health checks time out)
        vitessio#4837 refresh bug around row streamer handling creds
        vitessio#4830 apply a default value to the db_name attribute in local_metadata
        vitessio#4785 SHOW SCHEMAS aliased to SHOW DATABASES
        vitessio#4829 add experimental support for split clone & vertical split clone via vreplication
        vitessio#4822 do not normalize in order by
        vitessio#4791 Adds vreplication row streaming support
        vitessio#4814 command line flags now used regardless of management mode
        vitessio#4811 vttablet sets super_read_only during planned reparent
        vitessio#4803 xtrabackup testing
        vitessio#4727 support multiple vttablets running against one mysql instance
        vitessio#4746 TopoCat can now produce JSON output
        vitessio#4805 mysqld is now restarted after a failed backup
        vitessio#4685 macos bootstrap bug
        vitessio#4874 ZK opts and java land
        vitessio#4695 Adds support for xtrabackup
        vitessio#4794 fixes build failures
        vitessio#4725 changes mysql8.0 start args
        vitessio#4736 introduce new states to support vreplication
        vitessio#4788 expands orc error

**Docs etc**  
        vitessio#4831 lint
        vitessio#4827 docs
        vitessio#4816 const declaration cleanup
        vitessio#4820 const declaration cleanup
        vitessio#4825 docs
        vitessio#4818 docs
        vitessio#4809 docs
        vitessio#4812 moves consts around
        vitessio#4813 docs
        vitessio#4808 docs
        vitessio#4800 docs
        vitessio#4795 docs
@deepthi deepthi deleted the ds-mysql80-docker branch July 6, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekperkins derekperkins derekperkins approved these changes

@dkhenry dkhenry Awaiting requested review from dkhenry

@sougou sougou Awaiting requested review from sougou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deepthi @derekperkins @sougou @dkhenry