Skip to content

fix comments in tests #4575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 1 commit into from
Jan 31, 2019
Merged

fix comments in tests #4575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/vt/vtgate/executor_select_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ func TestSelectKeyRangeUnique(t *testing.T) {
func TestSelectIN(t *testing.T) {
executor, sbc1, sbc2, sbclookup := createExecutorEnv()

// Constant in IN clause, not a bind variable.
// Constant in IN clause is just a number, not a bind variable.
_, err := executorExec(executor, "select id from user where id in (1)", nil)
if err != nil {
t.Error(err)
Expand All @@ -614,7 +614,7 @@ func TestSelectIN(t *testing.T) {
t.Errorf("sbc2.Queries: %+v, want nil\n", sbc2.Queries)
}

// Constant IN is just a couple numbers, not bind variables.
// Constants in IN clause are just numbers, not bind variables.
// They result in two different queries on two shards.
sbc1.Queries = nil
sbc2.Queries = nil
Expand Down
4 changes: 2 additions & 2 deletions go/vt/vtgate/executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1841,7 +1841,7 @@ func TestExecutorUnrecognized(t *testing.T) {
func TestExecutorMessageAckSharded(t *testing.T) {
executor, sbc1, sbc2, _ := createExecutorEnv()

// Constant in IN clause, not a bind variable.
// Constant in IN clause is just a number, not a bind variable.
ids := []*querypb.Value{{
Type: sqltypes.VarChar,
Value: []byte("1"),
Expand All @@ -1860,7 +1860,7 @@ func TestExecutorMessageAckSharded(t *testing.T) {
t.Errorf("sbc2.MessageIDs: %+v, want nil\n", sbc2.MessageIDs)
}

// Constant IN is just a couple numbers, not bind variables.
// Constants in IN clause are just numbers, not bind variables.
// They result in two different MessageIDs on two shards.
sbc1.MessageIDs = nil
sbc2.MessageIDs = nil
Expand Down