Skip to content

Adding a reset of the slave on blank restore #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 1 commit into from
Jan 26, 2019
Merged

Adding a reset of the slave on blank restore #4552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions go/vt/mysqlctl/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,12 @@ func Restore(
if len(bhs) == 0 {
// There are no backups (not even broken/incomplete ones).
logger.Errorf("No backup to restore on BackupStorage for directory %v. Starting up empty.", dir)
// Since this Was an empty database make sure we start replication at the beginning
if err = mysqld.ResetReplication(ctx); err == nil {
logger.Errorf("Error reseting slave replication: %v. Continuing", err)
err = ErrNoBackup
}

if err = PopulateMetadataTables(mysqld, localMetadata); err == nil {
err = ErrNoBackup
}
Expand Down