Skip to content

Revert "Support tables that have columns named desc"#4526

Merged
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:revert-4513-add-support-for-columns-named-desc
Jan 16, 2019
Merged

Revert "Support tables that have columns named desc"#4526
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:revert-4513-add-support-for-columns-named-desc

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Jan 15, 2019

@sougou - it seems like the easy fix that we use for #4172, does not work here because desc is also in the reserved_keyword. I missed this comment:

/*
  These are not all necessarily reserved in MySQL, but some are.

  These are more importantly reserved because they may conflict with our grammar.
  If you want to move one that is not reserved in MySQL (i.e. ESCAPE) to the
  non_reserved_keywords, you'll need to deal with any conflicts.

  Sorted alphabetically
*/

I'm reverting this change for now, not sure right now how to solve the conflicts in the grammar.

Signed-off-by: Rafael Chacon rafael@slack-corp.com

@rafael rafael requested a review from sougou as a code owner January 15, 2019 16:01
@rafael rafael force-pushed the revert-4513-add-support-for-columns-named-desc branch from 4c76fe9 to 129fbf0 Compare January 15, 2019 16:07
This reverts commit 698aa37.

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael force-pushed the revert-4513-add-support-for-columns-named-desc branch from 129fbf0 to 7bd3486 Compare January 15, 2019 16:09
@sougou sougou merged commit b776864 into vitessio:master Jan 16, 2019
@rafael rafael deleted the revert-4513-add-support-for-columns-named-desc branch January 16, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants