Revert "Support tables that have columns named desc"#4526
Merged
sougou merged 1 commit intovitessio:masterfrom Jan 16, 2019
Merged
Conversation
4c76fe9 to
129fbf0
Compare
This reverts commit 698aa37. Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
129fbf0 to
7bd3486
Compare
sougou
approved these changes
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sougou - it seems like the easy fix that we use for #4172, does not work here because
descis also in the reserved_keyword. I missed this comment:I'm reverting this change for now, not sure right now how to solve the conflicts in the grammar.
Signed-off-by: Rafael Chacon rafael@slack-corp.com