Skip to content

Adds removed vschema#4434

Merged
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:add-vschema-local-examples
Dec 9, 2018
Merged

Adds removed vschema#4434
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:add-vschema-local-examples

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Dec 8, 2018

Description

  • This vschema is still used by Vagrant setup. It was removed in a previous refactor. We can fully deprecate later by refactoring Vagrant start script to not use it.

Adds removed vschema
841e07c 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner December 8, 2018 20:09
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Dec 9, 2018

lgtm

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Dec 9, 2018

I'm going to add this to 3.0. Might as well, because there's one more fix needed for the local example.

@sougou sougou merged commit 7f0ee4c into vitessio:master Dec 9, 2018
@setassociative setassociative mentioned this pull request Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sougou sougou sougou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rafael @deepthi @sougou