Skip to content

adapt helm/k8s example to run locally#4427

Merged
sougou merged 3 commits intovitessio:masterfrom
planetscale:ds-local-example
Dec 6, 2018
Merged

adapt helm/k8s example to run locally#4427
sougou merged 3 commits intovitessio:masterfrom
planetscale:ds-local-example

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Dec 6, 2018

Now available under examples/local.

Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner December 6, 2018 02:00
@sougou
Copy link
Copy Markdown
Contributor

sougou commented Dec 6, 2018

Awesome work 💯 !
Can you also delete all the unwanted artifacts, like client.sh, sharded-vttablet, etc?

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Copy Markdown
Collaborator Author

deepthi commented Dec 6, 2018

I have removed sharded-*.sh. I am reluctant to remove client.sh, client.py etc. because these are valuable sample scripts.
Should we move them elsewhere?

Can you also delete all the unwanted artifacts, like client.sh, sharded-vttablet, etc?

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Dec 6, 2018

They currently demonstrate a non-idiomatic way of connecting (grpc). But it's ok to keep them until my app is ready.

@sougou sougou merged commit f2118cc into vitessio:master Dec 6, 2018
@deepthi deepthi deleted the ds-local-example branch January 11, 2019 01:24
@deepthi deepthi changed the title WIP: adapt helm/k8s example to run locally adapt helm/k8s example to run locally Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants