config: loose options for MySQL 8 compatibility#4417
Closed
derekperkins wants to merge 1 commit intovitessio:masterfrom
Closed
config: loose options for MySQL 8 compatibility#4417derekperkins wants to merge 1 commit intovitessio:masterfrom
derekperkins wants to merge 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Contributor
|
This looks good to me. These modifiers are documented here in case @sougou would like to review them https://dev.mysql.com/doc/refman/5.7/en/option-modifiers.html |
Member
Author
|
Closing in favor of #4419 and a future PR adding a MySQL 8 flavor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been some
my.cnfoptions that don't work for forward / backward compatibility. Prefixing loose should only enforce those options on versions that support them.