Shard splitting using consistent snapshots#4395
Closed
systay wants to merge 3 commits intovitessio:masterfrom
Closed
Shard splitting using consistent snapshots#4395systay wants to merge 3 commits intovitessio:masterfrom
systay wants to merge 3 commits intovitessio:masterfrom
Conversation
Collaborator
Author
|
I'm going to stop updating this PR until the two it depends on have been merged |
sougou
reviewed
Dec 15, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
This change looks good. I'll do a final once-over after we resolve the other PR.
systay
force-pushed
the
all-together
branch
2 times, most recently
from
acc2dc9 to
b42aab9
Compare
added 2 commits
January 21, 2019 14:00
This makes it possible to use consistent snapshots instead of pausing replication during shard splits. Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Collaborator
Author
|
Will restart this PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #4310 and #4281, and contains the same changes as those. It's only the last commit that is unique to this PR.