Initial support for Connection Attributes#4370
Merged
sougou merged 3 commits intovitessio:masterfrom Nov 18, 2018
Merged
Conversation
By setting CapabilityClientConnAttr in the ServerGreeting the client starts to send key/value pairs in the login packet. The keys vary per client but often include client pid, client version client program, driver version, user on the client Signed-off-by: Daniël van Eeden <git@myname.nl>
Signed-off-by: Daniël van Eeden <git@myname.nl>
sougou
reviewed
Nov 17, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Looks good. Can you write a test that demonstrates how this works? Either in server_test.go or handshake_test.go.
dveeden
commented
Nov 17, 2018
| authMethod = MysqlNativePassword | ||
| } | ||
|
|
||
| // FIXME(alainjobart) Add CLIENT_CONNECT_ATTRS parsing if we need it. |
Signed-off-by: Daniël van Eeden <git@myname.nl>
sougou
approved these changes
Nov 18, 2018
This was referenced Dec 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the flag to allow the client to send connection attributes.
And then connection attributes are decoded.
Issue: #4369