Allow docker builds to disable CGO.#4363
Merged
sougou merged 1 commit intovitessio:masterfrom Nov 16, 2018
Merged
Conversation
Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
dkhenry
approved these changes
Nov 16, 2018
Contributor
dkhenry
left a comment
dkhenry
left a comment
There was a problem hiding this comment.
LGTM,
As a note this will switch the default to be CGO_ENABLED=0. I have tested that this is working with the rest of the docker images and everything looks good so far. I don't know if we want to send a message on #vitess to let people know master is switching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Pawliszyn mikepaw@squareup.com