helm: logging improvements#4343
Merged
derekperkins merged 10 commits intovitessio:masterfrom Nov 9, 2018
Merged
Conversation
group=2000 + user=1000 to match existing helm vttablet deployments Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
dkhenry
reviewed
Nov 6, 2018
Member
Author
|
There are two things still bothering me about logging.
|
Signed-off-by: Derek Perkins <derek@derekperkins.com>
the previous method didn’t listen for SIGTERM and so would block restarting Signed-off-by: Derek Perkins <derek@derekperkins.com>
this doesn’t require root privileges to run, and also listens for SIGTERM Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
also rename slow.log to slow-query.log to match Vitess defaults Signed-off-by: Derek Perkins <derek@derekperkins.com>
97ca0be to
c15a90f
Compare
Signed-off-by: Derek Perkins <derek@derekperkins.com>
080d0e5 to
c9e5b22
Compare
Member
Author
|
Ok, I solved those two problems.
This has been bugging me for a year and I feel pretty good about these changes. @dkhenry - if you could take another look, I made a lot of changes after your last LGTM. |
Contributor
This is a great quality of life improvement 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds log rotation via logrotate to the helm chart. By default, it rotates logs at 100M, running on an hourly cron.
This also uses the same
debian:stretch-slimto tail the error and slow logs, and adds a vitess user/group.@sougou - Can you create a new Docker repo for
logrotateandlogtailand have them auto-build like the others?