Add ability to hash the from value of lookup vindexes#4339
Merged
sougou merged 1 commit intovitessio:masterfrom Nov 9, 2018
Merged
Add ability to hash the from value of lookup vindexes#4339sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
eeSeeGee
force-pushed
the
young.20181105.hash_from_ids
branch
from
27a028b to
ea3f693
Compare
sougou
reviewed
Nov 9, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Looks like I didn't convey correctly what I meant. Basically, lookup_internal.go should be unchanged. The md5 should be done by lookup_unicodeloosemd5_hash.go. It's kind of similar to how lookup_hash.go does it, but instead, should hash the from key before sending it to lookup internal.
Contributor
Author
|
I see, ugly solution incentivizes refactoring it out. |
Signed-off-by: Aaron Young <aaron.young@gmail.com>
eeSeeGee
force-pushed
the
young.20181105.hash_from_ids
branch
from
ea3f693 to
e4e0d00
Compare
sougou
approved these changes
Nov 9, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Yeah. I can totally see this spiraling out of control eventually. But it's ok for now. After a few more such offshoots, we'll need to wrangle this with better composability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Young aaron.young@gmail.com