Merged
Conversation
added 2 commits
October 31, 2018 13:55
There is a race condition where PMM can come up before the `mysql.sock` file is ready. PMM will fail to start and then permanently crash. Instead, wait for the sock file to be available and then proceed with PMM initialization. Also, latest fix to the `vitess/pmm-client` image means we no longer need the `|| true` fix for `pmm-admin add`. Signed-off-by: Mark Solters <msolters@gmail.com>
Installing `procps` in the `vitess/pmm-client` image resolves issue https://jira.percona.com/projects/PMM/issues/PMM-1985 Signed-off-by: Mark Solters <msolters@gmail.com>
Contributor
Author
|
With these changes I can confirm PMM successfully starts up without the errors noted in https://jira.percona.com/projects/PMM/issues/PMM-1985, and MySQL statistics are correctly scraped by pmm-server. (Percona QAN data is still not available, that might be an orthogonal issue.) |
derekperkins
approved these changes
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race condition where PMM can come up before the
mysql.sockfile is ready. PMM will fail to start and then permanently crash. Instead, wait for the sock file to be available and then proceed with PMM initialization.Also, latest fix to the
vitess/pmm-clientimage means we no longer need the|| truefix forpmm-admin add.