Skip to content

No panic when could not find glog flag.#4328

Merged
sougou merged 1 commit intovitessio:masterfrom
kuba--:no-panic
Nov 4, 2018
Merged

No panic when could not find glog flag.#4328
sougou merged 1 commit intovitessio:masterfrom
kuba--:no-panic

Conversation

@kuba--
Copy link
Copy Markdown
Collaborator

@kuba-- kuba-- commented Oct 31, 2018

Signed-off-by: kuba-- kuba@sourced.tech

What we have in go/vt/logutil/level.go is bad.
In file go/vt/log/log.go it says:

You can modify this file to hook up a different logging library instead of glog.

But actually level.go is looking for glog flags (stderrthreshold) and panics (if not found)!

This PR (at least) removes panic from init function.

Signed-off-by: kuba-- <kuba@sourced.tech>
@kuba--
Copy link
Copy Markdown
Collaborator Author

kuba-- commented Nov 2, 2018

  • why SHARD4 is failing with ./test.go:880: d.Round undefined (type time.Duration has no field or method Round)?
    It's totally not related to PR.

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Nov 2, 2018

Not sure what happened. But the retry succeeded. I plan on reviewing all pending PRs by EOW.

@sougou sougou merged commit 041f2a0 into vitessio:master Nov 4, 2018
@kuba-- kuba-- deleted the no-panic branch November 4, 2018 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants