[go/mysql] implement Shutdown for mysql.lListener#4285
Merged
sougou merged 1 commit intovitessio:masterfrom Oct 20, 2018
LK4D4:graceful_shutdown
Merged
[go/mysql] implement Shutdown for mysql.lListener#4285sougou merged 1 commit intovitessio:masterfrom LK4D4:graceful_shutdown
sougou merged 1 commit intovitessio:masterfrom
LK4D4:graceful_shutdown
Conversation
This method closes listener and forces all Ping requests to fail with ERServerShutdown. I used https://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_server_shutdown as a reference. Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
danieltahara
left a comment
danieltahara
left a comment
There was a problem hiding this comment.
lgtm modulo questions. deferring to @sougou for review
| SSHandshakeError = "08S01" | ||
|
|
||
| // SSServerShutdown is ER_SERVER_SHUTDOWN | ||
| SSServerShutdown = "08S01" |
There was a problem hiding this comment.
this is the same # as above. is that right?
Contributor
Author
There was a problem hiding this comment.
Yeah, and there is one more above it. I'm not sure what does it mean, but that's state from the reference manual for that type of error.
sougou
approved these changes
Oct 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method closes listener and forces all Ping requests to fail with ERServerShutdown.
The idea is to use this mechanism for graceful stop, we shutdown listener and clients will know that they should finish their work on connection ASAP
I used
https://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_server_shutdown
as a reference.
/cc @danieltahara