Merged
Conversation
demmer
force-pushed
the
vtgate-support-warnings
branch
2 times, most recently
from
654d58c to
7e6ecda
Compare
sougou
approved these changes
Oct 27, 2018
Contributor
|
Need to resolve parser conflicts. |
To enable conveying out of band warnings, add a new proto definition for a QueryWarning and add a repeated array to the vtgate session. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
demmer
force-pushed
the
vtgate-support-warnings
branch
from
ea15cc3 to
4095e4c
Compare
Member
Author
|
@sougou -- Rebased and resolved parser conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add warnings to the vtgate session. (Part 3 of #4279)
Details
Extend the vtgate.Session proto object to include an array of QueryWarnings, each with a code and warning string.
Add support for
SHOW WARNINGSto return them to the caller.