Skip to content

allow IGNORE in update sql statements #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 3 commits into from
Oct 18, 2018
Merged

allow IGNORE in update sql statements #4277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c51137c
allow IGNORE in update sql statements
deepthi Oct 16, 2018
7b9ab12
use latest goyacc to avoid trivial diff causing CI failure
deepthi Oct 17, 2018
138b06e
fix comment per review
deepthi Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions go/vt/sqlparser/ast.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@ func (*ParenSelect) iInsertRows() {}
// If you add fields here, consider adding them to calls to validateSubquerySamePlan.
type Update struct {
Comments Comments
Ignore string
TableExprs TableExprs
Exprs UpdateExprs
Where *Where
Expand All @@ -596,8 +597,8 @@ type Update struct {

// Format formats the node.
func (node *Update) Format(buf *TrackedBuffer) {
buf.Myprintf("update %v%v set %v%v%v%v",
node.Comments, node.TableExprs,
buf.Myprintf("update %v%s%v set %v%v%v%v",
node.Comments, node.Ignore, node.TableExprs,
node.Exprs, node.Where, node.OrderBy, node.Limit)
}

Expand Down
2 changes: 2 additions & 0 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,8 @@ var (
}, {
input: "update foo f join bar b on f.name = b.name set f.id = b.id where b.name = 'test'",
output: "update foo as f join bar as b on f.name = b.name set f.id = b.id where b.name = 'test'",
}, {
input: "update /* ignore */ ignore a set b = 3",
}, {
input: "delete /* simple */ from a",
}, {
Expand Down
Loading