add a raw ParseTokenizer interface to call yyParse under the hood#4250
Merged
sougou merged 1 commit intovitessio:masterfrom Oct 8, 2018
Merged
add a raw ParseTokenizer interface to call yyParse under the hood#4250sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
The prior change to use pooled parsers meant that the generated yyParse function was unused, triggering warnings from the `unused` vet tool. Add a public interface `ParseTokenizer` so that these unused warnings no longer show up. Plus this _could_ be useful for some third-party that wants to have raw access to the underlying tokenizer / parser. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Member
Author
|
@sougou / @danieltahara I ran into an issue while developing a new grammar feature where the recent change to pool parsers meant that I think it's best if we either silence that warning altogether for this whole package or we do something like this to actually call yyParse. I have no allegiance to the particular function I chose, it just seemed like the simplest. |
|
Seems completely reasonable. |
danieltahara
approved these changes
Oct 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior change to use pooled parsers meant that the generated
yyParse function was unused, triggering warnings from the
unusedvet tool.
Add a public interface
ParseTokenizerso that these unused warningsno longer show up. Plus this could be useful for some third-party
that wants to have raw access to the underlying tokenizer / parser.