Merged
Conversation
* Add logging when using s3 for: StartBackup / ListBackups / RemoveBackup
* Added options to enable usage of an S3 appliance: Cloudian HyperStore:
-s3_backup_aws_endpoint <host:port> (port is required)
-s3_backup_force_path_style=true/false
By default the s3 client will try to connect to
<path>.<region>.amazonaws.com. Adjusting the endpoint will allow this
to be changed.
Given the way the FQDN is configured the TLS certificate may not match the
server's "base" (<region>.<end_point_address>) due to the leading <path>
so setting -s3_backup_force_path_style=true will force the s3 client to
connect to <region>.<endpoint> and then make a request using the full
path within the http calls.
Signed-off-by: Simon Mudd <simon.mudd@booking.com>
Signed-off-by: Scott Lanning <scott.lanning@booking.com>
In case for some reason the SSL certificate is invalid... this flag allows disabling the validity check. Signed-off-by: Scott Lanning <scott.lanning@booking.com>
sougou
approved these changes
Sep 24, 2018
Member
|
This PR introduces a regression. The default value for the following option isn't correct: As a workaround, we managed to change the setting to |
Contributor
Author
|
Oops, I'll make a PR. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to supersede #4068
and cherry-picked the commit from that.
(I just made a new PR because I think I can't push to Simon's.)
On top of that, it fixes some log output (*bucket)
and adds a flag to allow disabling SSL certificate validity check
(not sure why it's hard to fix the certificate..).