Handle bit types properly so that UPDATE and DELETE work as expected during replication#4167
Merged
sougou merged 8 commits intovitessio:masterfrom Sep 5, 2018
Merged
Conversation
… literals Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
…n't fail tests on string field table Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
changed the title
sougou
reviewed
Sep 2, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Very nice work, especially for a first PR. This was a tough one :).
I reviewed the code by looking at all use cases of IsQuoted:
- In type.go, there is a comment that says:
the following conditions are non-overlapping....Bitshould be added to this list. This is also what triggered my review of all places whereIsQuotedis used. - Although not critical,
StringandMarshalJSONcould be improved. - I checked the
Castfunction in arithmetic.go. No change was needed there. So, we're good.
In other words, there are a few minor things to fix, and this PR can be merged.
Signed-off-by: deepthi <deepthi@planetscale.com>
Collaborator
|
YAY! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #4145.
Changed how bit literals are handled in vitess so that BIT fields are matched correctly for UPDATE / DELETE.
Instead of converting them to '\x0...' format, we will convert them to b'...' format.