add support for vtexplain to override the dbname target#4150
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 24, 2018
Merged
add support for vtexplain to override the dbname target#4150sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
This change adds a --dbname option to the vtexplain binary so that callers can simulate what vtgate will do when the application connects with a specific database name. Add a test to show how this can be used to bypass the v3 routing and send queries directly to a shard. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
sougou
approved these changes
Aug 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a --dbname option to the vtexplain binary so that
callers can simulate what vtgate will do when the application connects
with a specific database name.
Add a test to show how this can be used to bypass the v3 routing and
send queries directly to a shard.
As an example, I used the same queries as the "options" test in a new "target" test where the shard is forced to
ks_sharded/-40: