Delay VTGateConnection closure when rotating connections#4141
Merged
sougou merged 5 commits intovitessio:masterfrom Aug 22, 2018
Merged
Delay VTGateConnection closure when rotating connections#4141sougou merged 5 commits intovitessio:masterfrom
sougou merged 5 commits intovitessio:masterfrom
Conversation
added 4 commits
August 16, 2018 13:34
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
leoxlin
changed the title
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
leoxlin
force-pushed
the
delay-channel-closure
branch
from
77a73d6 to
f0517ca
Compare
Member
|
I will look into this week. |
harshit-gangal
approved these changes
Aug 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At HubSpot we see a lot high volume applications take a lot of impact during channel rotations due to a race condition that will provide a shutdown channel to the
VitessStatementandVitessPreparedStatementwhen the certificate rotator thread closes theVTGateConnectionThis PR adds a more graceful way to handle refresh channel closures by adding a strategy to delay closure of the connection to a later time.
This will reduce the pain on any currently running transactions as well as any stream calls that had not completed when the rotation happens.
@acharis @harshit-gangal