Fix issue where different workflows incorrectly get flags from a diff…#4137
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 20, 2018
Merged
Conversation
…erent one Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
dkhenry
approved these changes
Aug 20, 2018
Contributor
dkhenry
left a comment
dkhenry
left a comment
There was a problem hiding this comment.
Looks fine, this does require that any flags on future workflows have the factory prefixed on the flag name. It appears all current workflow flags follow this convention, but there doesn't appear to be anything stopping me from not doing that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desc
This fixes a small issue in the UI where flags from different workflows get combined when they should not. Before this change:
After this change: