Fix getGeneratedKeys when no insert during batch upsert#4136
Merged
sougou merged 4 commits intovitessio:masterfrom Sep 1, 2018
Merged
Fix getGeneratedKeys when no insert during batch upsert#4136sougou merged 4 commits intovitessio:masterfrom
sougou merged 4 commits intovitessio:masterfrom
Conversation
added 3 commits
August 14, 2018 22:08
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Member
|
I will look into this week. |
harshit-gangal
requested changes
Aug 26, 2018
Member
harshit-gangal
left a comment
harshit-gangal
left a comment
There was a problem hiding this comment.
Changes looks good overall.
| if (this.retrieveGeneratedKeys) { | ||
| generatedKeys[i] = new long[]{cursorWithError.getCursor().getInsertId(), truncatedUpdateCount}; | ||
| long insertId = cursorWithError.getCursor().getInsertId(); | ||
| if (this.retrieveGeneratedKeys && !queryBatchUpsert || insertId > 0) { |
Member
There was a problem hiding this comment.
nit: good to put brackets for clarity . a && (b || c)
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
harshit-gangal
approved these changes
Aug 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We uses batched upsert statements at HubSpot and have seen inconsistent behaviors between MySQL vs Vitess. We saw that a statement doing
ON DUPLICATE KEY UPDATEwill return[0]even when no new rows was inserted.java.sql.StatementexpectsgetGeneratedKeysto return an empty ResultSet when there are no keys generated by the statement.https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#getGeneratedKeys--
MySQLConnect4j checks for the
beginAt(insertId) before including an id into the generatedKeys set.https://github.com/mysql/mysql-connector-j/blob/9cc87a48e75c2d2e87c1a293b2862ce651cb256e/src/com/mysql/jdbc/StatementImpl.java#L1750
@acharis @harshit-gangal