Skip to content

Allow overriding of the default keepalive server-side enforcement policy min time #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 3 commits into from
Aug 12, 2018
Merged

Allow overriding of the default keepalive server-side enforcement policy min time #4130

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5dd722
Set the keepalive server-side enforcement policy min time, so that
zmagg Aug 10, 2018
f08a394
Change the flag name to respond to code review.
zmagg Aug 10, 2018
d563f17
Use the new variable name.
zmagg Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions go/vt/servenv/grpc_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ var (
// The lower bound for window size is 64K and any value smaller than that will be ignored.
GRPCInitialWindowSize = flag.Int("grpc_server_initial_window_size", 0, "grpc server initial window size")

// EnforcementPolicy MinTime that sets the keepalive enforcement policy on the server.
// This is the minimum amount of time a client should wait before sending a keepalive ping.
GRPCKeepAliveEnforcementPolicyMinTime = flag.Duration("grpc_server_keepalive_enforcement_policy_min_time", 5*time.Minute, "grpc server minimum keepalive time")

authPlugin Authenticator
)

Expand Down Expand Up @@ -143,6 +147,11 @@ func createGRPCServer() {
opts = append(opts, grpc.InitialWindowSize(int32(*GRPCInitialWindowSize)))
}

ep := keepalive.EnforcementPolicy{
MinTime: *GRPCKeepAliveEnforcementPolicyMinTime,
}
opts = append(opts, grpc.KeepaliveEnforcementPolicy(ep))

if GRPCMaxConnectionAge != nil {
ka := keepalive.ServerParameters{
MaxConnectionAge: *GRPCMaxConnectionAge,
Expand Down