[Sqlparser] SET TRANSACTION has special semantics#4128
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 12, 2018
Merged
[Sqlparser] SET TRANSACTION has special semantics#4128sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
danieltahara
force-pushed
the
extract-set
branch
from
cf14ba1 to
6c5f1a2
Compare
Per vitessio#4127, SET TRANSACTION ... has different semantics in absence of {SESSION,GLOBAL} than does SET tx_isolation or SET tx_readonly. Modify the data structures to reflect that difference. Signed-off-by: Daniel Tahara <tahara@dropbox.com>
danieltahara
force-pushed
the
extract-set
branch
from
6c5f1a2 to
adeacf5
Compare
danieltahara
requested review from
demmer and
sougou
and removed request for
demmer
sougou
approved these changes
Aug 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #4127, SET TRANSACTION ...
has different semantics in absence of {SESSION,GLOBAL} than does SET
tx_isolation or SET tx_readonly. Modify the data structures to reflect
that difference.
Signed-off-by: Daniel Tahara tahara@dropbox.com