Merged
Conversation
added 2 commits
August 7, 2018 16:40
…eing block Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
nit - formatting issue Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
demmer
approved these changes
Aug 7, 2018
Member
demmer
left a comment
demmer
left a comment
There was a problem hiding this comment.
LGTM with one minor logging suggestion
| select { | ||
| case <-p.ctx.Done(): | ||
| log.Info("Workflow is cancelled, will not run task: %v", task) | ||
| log.Infof("Workflow is cancelled, will not run task: %v", task) |
Member
There was a problem hiding this comment.
This log message is somewhat misleading since it will not run this task or all subsequent ones, right?
Member
Author
There was a problem hiding this comment.
Yeah that is correct. How would you phrase it?
Maybe just:
log.Infof("Workflow is cancelled, current task and subsequent tasks will be aborted")
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desc
This fixes a small but annoying where trying to
Stopa workflow that was waiting approval for aSequentialstep just hangs.This was due to not having enough semaphores in the running tasks loops. I fixed this by just returning the whole method early if the context is done.
Tests