[MySQL][Conn] Recyle write buffers if allocated#4120
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 12, 2018
Merged
Conversation
Author
|
Need to fix some things. |
danieltahara
force-pushed
the
recycle-write
branch
2 times, most recently
from
cc25182 to
cf4c53e
Compare
Author
|
Relevant here. Profile of a process with about 35k client connections doing 1500 actual RPS. We bloat up to 1.5G of memory allocated by startEphemeralPacket on the write side, since we're not actually releasing the buffer. |
danieltahara
force-pushed
the
recycle-write
branch
3 times, most recently
from
766fa98 to
53357e6
Compare
After passing off the information needed from a read buffer, we recycle it with recycleReadPacket(). We don't do the same with writes, which means we hang out to allocated memory (in the case of ephemeralWriteSingleBuffer and ephemeralWriteBigBuffer) until the next write on the connection needs to allocate a new buffer (i.e. not using the global buffer). In steady state, this means we will gradually accumulate large buffers without ever letting them be GCed. This is wasteful, so add an analagous recycleWritePacket(). Signed-off-by: Daniel Tahara <tahara@dropbox.com>
danieltahara
force-pushed
the
recycle-write
branch
from
53357e6 to
a11b481
Compare
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After passing off the information needed from a read buffer, we recycle
it with recycleReadPacket(). We don't do the same with writes, which
means we hang out to allocated memory (in the case of
ephemeralWriteSingleBuffer and ephemeralWriteBigBuffer) until the next
write on the connection needs to allocate a new buffer (i.e. not using
the global buffer). In steady state, this means we will gradually
accumulate large buffers without ever letting them be GCed. This is
wasteful, so add an analagous recycleWritePacket().
Signed-off-by: Daniel Tahara tahara@dropbox.com