Go 1.11 fix for certificate common name.#4114
Merged
alainjobart merged 1 commit intovitessio:masterfrom Jul 30, 2018
Merged
Conversation
michael-berlin
approved these changes
Jul 30, 2018
go/mysql/handshake_test.go
Outdated
Contributor
There was a problem hiding this comment.
How about server.example.com?
That's an intentionally reserved domain which can be used in documentations. See www.example.com.
Contributor
Author
There was a problem hiding this comment.
Done, for both tests, and rebased / squashed.
In go 1.11, common name is ignored when it doesn't parse as a host name. See this change: https://go-review.googlesource.com/c/go/+/123355 So we make it look like a host name in tests. Also add ServerName to MySQL conn parameters, so it can be specified explicitely, instead of using the defaults always. Signed-off-by: Alain Jobart <alainjobart@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In go 1.11, common name is ignored when it doesn't parse as a host name.
See this change:
https://go-review.googlesource.com/c/go/+/123355
So we make it look like a host name in tests.
Also add ServerName to MySQL conn parameters, so it can be specified
explicitely, instead of using the defaults always.
Signed-off-by: Alain Jobart alainjobart@google.com